Adds simple documentation for the test executions code lenses #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blond11516
commented
Jul 10, 2021
Comment on lines
+129
to
+131
| #### Known issues | ||
|
|
||
| - The generated command sometimes fails to properly execute tests in umbrella apps. See [this comment](https://github.com/elixir-lsp/elixir-ls/issues/438#issuecomment-871861880) for more details. |
There was a problem hiding this comment.
As per this and the few following comments, this issue seems to be more about elixir-ls' test setup than the test lenses, so I guess this could be removed.
There was a problem hiding this comment.
I think it's better to leave it in for now in the chance that it affects other projects as well, and other projects may use a similar alias in their tests.
axelson
approved these changes
Jul 19, 2021
Comment on lines
+129
to
+131
| #### Known issues | ||
|
|
||
| - The generated command sometimes fails to properly execute tests in umbrella apps. See [this comment](https://github.com/elixir-lsp/elixir-ls/issues/438#issuecomment-871861880) for more details. |
There was a problem hiding this comment.
I think it's better to leave it in for now in the chance that it affects other projects as well, and other projects may use a similar alias in their tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents the test execution code lenses as an experimental feature.
I wasn't quite sure how to integrate this with the rest of the README. I opted for an independent "Experimental Features" section as I feel these are not as important as the configuration, troubleshooting, etc.